Remove obsolete toml import from the test suite
#1978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mgorny do you mind rebasing your PR? |
Remove the `toml` import that is used to determine whether to run `pyproject.toml` test. Firstly, `toml` has been replaced by `tomli`. Secondly, isort vendors `tomli`, so checking for its availability does not seem to make sense.
|
Rebased. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1978 +/- ##
=======================================
Coverage 98.80% 98.80%
=======================================
Files 38 38
Lines 3084 3084
Branches 745 745
=======================================
Hits 3047 3047
Misses 26 26
Partials 11 11 |
|
Thank you! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
tomlimport that is used to determine whether to runpyproject.tomltest. Firstly,tomlhas been replaced bytomli. Secondly, isort vendorstomli, so checking for its availability does not seem to make sense.