Apply the bracket fix from issue 471 only for use_parentheses=True#2184
Merged
staticdev merged 2 commits intoPyCQA:mainfrom Dec 13, 2023
Merged
Apply the bracket fix from issue 471 only for use_parentheses=True#2184staticdev merged 2 commits intoPyCQA:mainfrom
staticdev merged 2 commits intoPyCQA:mainfrom
Conversation
Collaborator
|
@bp72 LGTM, do you mind rebasing to current code so we can see checks/pipelines run? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2184 +/- ##
=======================================
Coverage 99.15% 99.15%
=======================================
Files 39 39
Lines 3090 3091 +1
Branches 748 748
=======================================
+ Hits 3064 3065 +1
Misses 15 15
Partials 11 11 |
Contributor
Author
|
One test has failed, I'm not sure yet why, hmm. |
Contributor
Author
|
I added a fix for the error that was caught by |
staticdev
approved these changes
Dec 13, 2023
Collaborator
|
@bp72 we can deal with complexity in a new pr if you want. LGTM. |
Contributor
Author
|
@staticdev thank you for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2154
_commenttonoqa_comment