Merged
Conversation
Fix `called_once()` assertions in `test_git_hook` to use the correct `assert_called_once()` method. The former does not exist, so it evaluates to a mocked method in Python < 3.12, making the assert meaningless, and it triggers an error in Python 3.12+. While at it, split the mock into two because otherwise the test would fail because two `hooks.git_hook()` calls imply two mock calls.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2196 +/- ##
=======================================
Coverage 99.22% 99.22%
=======================================
Files 38 38
Lines 3087 3087
Branches 747 747
=======================================
Hits 3063 3063
Misses 14 14
Partials 10 10 |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
called_once()assertions intest_git_hookto use the correctassert_called_once()method. The former does not exist, so it evaluates to a mocked method in Python < 3.12, making the assert meaningless, and it triggers an error in Python 3.12+.While at it, split the mock into two because otherwise the test would fail because two
hooks.git_hook()calls imply two mock calls.