Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove optional dependencies without extras #2207

Merged
merged 1 commit into from
Dec 10, 2023

Conversation

staticdev
Copy link
Collaborator

Closes #2206

@staticdev staticdev added the bug Something isn't working label Dec 10, 2023
Copy link

codecov bot commented Dec 10, 2023

Codecov Report

Merging #2207 (f7a6b0e) into main (4be9850) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2207   +/-   ##
=======================================
  Coverage   99.15%   99.15%           
=======================================
  Files          39       39           
  Lines        3090     3090           
  Branches      748      748           
=======================================
  Hits         3064     3064           
  Misses         15       15           
  Partials       11       11           

@staticdev staticdev merged commit 64daf96 into main Dec 10, 2023
36 of 38 checks passed
@staticdev staticdev deleted the bugfix/#2206-remove-optional-dependencies branch December 10, 2023 15:11
@miketheman
Copy link

Thanks for the quick fix! Is there a plan to release this as 5.13.1 or such soon? The added deps fail our dependency update pipeline, and I'd prefer to not pin to isort prior to 5.13 to unblock it if possible.

@staticdev
Copy link
Collaborator Author

@miketheman done

@miketheman
Copy link

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lots of new direct dependencies [5.13]
2 participants