off by two

[bukzor]

The minimum complexity on the mccabe scale is one.
The simplest function should pass flake8 when max-complexity is 1.

There's two reasons this doesn't work:

• "max complexity" in fact specifies the minimum complexity which is not acceptable. Please note the difference in adjectives between the field's name and its description.
• The simplest function has a measured complexity of two. Using a definition from Wikipedia ( M = π − s + 2 where π is the number of decision points in the program, and s is the number of exit points), I count zero decision points and one exit point, resulting in M==1.

$ cat trivial.py 
def trivial():
    return None

$ flake8 --max-complexity 1 trivial.py 
trivial.py:1:1: C901 'trivial' is too complex (2)

[sigmavirus24]

That means that we're off by one, not by two.

[bukzor]

If you say so, but you'll find that there needs to be two off-by-one fixes to get the above scenario working properly:

1. Adjust the complexity measure to properly get a value of 1.
2. Adjust the max-complexity logic to accept a complexity of 1.

[schlamar]

@sigmavirus24 any ETA for a release? This bug is really annyoing...

[sigmavirus24]

@schlamar I never received the ability to ship a release from @florentx . You'll have to redirect that question to him.