remove handling of # type: comments now that pyflakes is py3+
#684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
going to merge this for now -- might revert it before the next release but I'd like to see it go out |
eli-schwartz
added a commit
to eli-schwartz/meson
that referenced
this pull request
Nov 24, 2022
flake8 6 upgrades to pyflakes 3, and in turn this means that support for parsing `# type: ` style annotations has been removed. PyCQA/pyflakes#684 This caused one file to fail linting, because it had a typing import which was only used by a type comment. ``` mesonbuild/cmake/interpreter.py:55:5: F401 '.common.CMakeConfiguration' imported but unused ``` Updating it to actual annotations allows pyflakes to detect its usage again, and flake8 passes. Do the whole file while we are here.
|
Just hit this when flake8 updated in CI, it gave me the right kick to finally update this old code... (we use modern annotation style in new code, of course). In case anyone else has the same issue, https://github.com/ilevkivskyi/com2ann seems useful to auto-migrate your code, so the change should be low-impact. |
eli-schwartz
added a commit
to eli-schwartz/meson
that referenced
this pull request
Nov 24, 2022
flake8 6 upgrades to pyflakes 3, and in turn this means that support for parsing `# type: ` style annotations has been removed. PyCQA/pyflakes#684 This caused one file to fail linting, because it had a typing import which was only used by a type comment. ``` mesonbuild/cmake/interpreter.py:55:5: F401 '.common.CMakeConfiguration' imported but unused ``` Updating it to actual annotations allows pyflakes to detect its usage again, and flake8 passes. Do the whole file while we are here.
mgedmin
added a commit
to mgedmin/check-python-versions
that referenced
this pull request
Nov 26, 2022
Flake8 explicitly dropped support for type comments: PyCQA/pyflakes#684
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #683