Add all default methods to view subclass validation function #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1433
💛 - Coveralls |
|
PR looks good but there are too many unrelated failures. Let me try fixing those up a bit before we can merge this. I want to see CI reporting PASS before pressing the button. |
atodorov
force-pushed
the
fix-view-methods-self
branch
from
c4bfa98 to
97193ee
Compare
…d_shouldnt_be_function
otherwise pylint complains
atodorov
force-pushed
the
fix-view-methods-self
branch
from
092ca68 to
364b26b
Compare
Django's View class doesn't implement a head() method but instead uses self.head = ... if the child class doesn't override it. This leads to the method-hidden checker being triggered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds all the Django's View class default HTTP methods to the
is_model_view_subclass_method_shouldnt_be_function.