This repository has been archived by the owner on Oct 2, 2023. It is now read-only.
Add other git servers to AdventOfCode cog #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
ghost
closed this
|
Closed the wrong pr, sry xD |
ghost
reopened this
|
@Defelo does this PR goes into the right direction? (this PR is getting more interesting as December approaches again ^^). What do you think about the code-complexity issue of codeclimate? |
|
Code Climate has analyzed commit db42a72 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Defelo
changed the title
Function checks url for all git server patterns. This way it is extendible and one doesn't have to check the type of the repo before calling the parsing function.
Function checks url for all git server patterns. This way it is extendible and one doesn't have to check the type of the repo before calling the function.
Rename the functions subject to be kept with the nice name.
Defelo
approved these changes
Dec 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this changes other git remove servers than
githubcan be added to AdventOfCode.Some of the functions are present only for the purpose of packing the
getand theparsefunctionality into one single function isn't desired for some coding style reason (even though I wouldn't see one). These functions are marked asTODO remove.Additional Notes
Please do not merge directly, because honestly since I don't know how to set this whole thing up with the database and so one, this code is untested. So you'll have to test this your own.