Skip to content
This repository has been archived by the owner on Oct 2, 2023. It is now read-only.

Added listing of roles #191

Closed
wants to merge 2 commits into from
Closed

Added listing of roles #191

wants to merge 2 commits into from

Conversation

Leminee
Copy link

@Leminee Leminee commented Feb 9, 2022

Description
Provide a description of what your changes do.

Issue
Closes #XX

Additional Notes
Add any other context about the pull request here.

@Leminee Leminee requested a review from a team as a code owner February 9, 2022 00:41
administration/roles/cog.py Show resolved Hide resolved
Comment on lines 145 to 149
list_of_server_roles = ctx.guild.roles
list_of_server_roles.reverse()
description = ""
for role in list_of_server_roles:
description += f":small_blue_diamond: {role.mention} ({role.color})\n"
Copy link

@ghost ghost Feb 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace this with:

description="\n".join([f":small_blue_diamond: {role.mention} ({role.color})" for role in ctx.guild.roles.reverse()])

@Leminee Leminee requested a review from a team as a code owner February 9, 2022 23:13
@codeclimate
Copy link

codeclimate bot commented Feb 9, 2022

Code Climate has analyzed commit 5c6dfec and detected 0 issues on this pull request.

View more on Code Climate.

Comment on lines +145 to +146
description = "\n".join(
t.description(role.mention, role.color) for role in ctx.guild.roles.reverse())
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls improve code-style

for role in list_of_server_roles:
description += f":small_blue_diamond: {role.mention} ({role.color})\n"
description = "\n".join(
t.description(role.mention, role.color) for role in ctx.guild.roles.reverse())

title = f"{len(ctx.guild.roles)} {t.roles}"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls use a translation for that (similar wit description )

@ghost ghost added the enhancement New feature or request label Feb 28, 2022
@ghost ghost assigned Leminee Feb 28, 2022
@Defelo Defelo assigned Defelo and unassigned Leminee Mar 29, 2022
@Leminee Leminee closed this Apr 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants