This repository has been archived by the owner on Oct 2, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
suggested changes
Feb 9, 2022
ghost
suggested changes
Feb 9, 2022
administration/roles/cog.py
Outdated
Comment on lines
145
to
149
list_of_server_roles = ctx.guild.roles | ||
list_of_server_roles.reverse() | ||
description = "" | ||
for role in list_of_server_roles: | ||
description += f":small_blue_diamond: {role.mention} ({role.color})\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace this with:
description="\n".join([f":small_blue_diamond: {role.mention} ({role.color})" for role in ctx.guild.roles.reverse()])
Code Climate has analyzed commit 5c6dfec and detected 0 issues on this pull request. View more on Code Climate. |
ghost
suggested changes
Feb 28, 2022
Comment on lines
+145
to
+146
description = "\n".join( | ||
t.description(role.mention, role.color) for role in ctx.guild.roles.reverse()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls improve code-style
for role in list_of_server_roles: | ||
description += f":small_blue_diamond: {role.mention} ({role.color})\n" | ||
description = "\n".join( | ||
t.description(role.mention, role.color) for role in ctx.guild.roles.reverse()) | ||
|
||
title = f"{len(ctx.guild.roles)} {t.roles}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls use a translation for that (similar wit description
)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide a description of what your changes do.
Issue
Closes #XX
Additional Notes
Add any other context about the pull request here.