This repository has been archived by the owner on Oct 2, 2023. It is now read-only.
Feature/poll rewrite #204
Closed
Feature/poll rewrite #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
Deploying with
|
| Latest commit: |
8f9609c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f54b2f53.pydrocsid-cogs.pages.dev |
| Branch Preview URL: | https://feature-poll-rewrite.pydrocsid-cogs.pages.dev |
added 2 commits
April 11, 2022 21:35
added 12 commits
April 12, 2022 14:17
added 2 commits
May 16, 2022 22:49
LoCrealloc
suggested changes
May 30, 2022
|
|
||
| parsed_options: list[tuple[str, str]] = [(obj.emoji, t.select.label(ix)) for ix, obj in enumerate(options, start=1)] | ||
|
|
||
| try: |
There was a problem hiding this comment.
use an if condition instead of this try-excpet-thing here (check for permissions first)
There was a problem hiding this comment.
problem with that is, that its not about the permission, its about the maximum pins per channel https://docs.pycord.dev/en/master/api.html?highlight=HTTPException%20pin#discord.Message.pin
Ari24-cb24
reviewed
Jun 17, 2022
LoCrealloc
suggested changes
Jun 20, 2022
| if _weight and weight < (_weight := float(_weight)): | ||
| weight = _weight | ||
|
|
||
| return weight |
There was a problem hiding this comment.
please dont calll it weight and _weight, thats very unreadable
|
Code Climate has analyzed commit 8f9609c and detected 0 issues on this pull request. View more on Code Climate. |
ghost
added
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Poll rewrite
Issue
Closes #140 #162