Bug: return value of OSFS.geturl cannot be consumed by FS on Windows #329
Comments
9 tasks
willmcgugan
pushed a commit
that referenced
this issue
Aug 23, 2019
* ✨ provide geturl for ReadZipFS. As a user of zipsf, I need geturl to provide FSURL string.
* 🐛 on windows and python 3, fs.open_fs(osfs(~/).geturl('myfolder/subfolder')) triggers CreateFailed
🐛 osfs.geturl() cannot be opened by itself
* 🔬 all test cases are in and ✨ support geturl for read tar file system
* 🔥 remove unwanted comment in code
* 📖 update change log and contributor md
* :short: update code with black
* 📖 update change log
* 👕 provide type info
* 💚 update unit tests
* 🔥 remove dead code
* 💚 update tarfs unit test
* 🔥 remove unwanted change
* :short: run black over osfs.py
* 🐛 fix hidden exception at fs.close() when opening an absent zip/tar file URL. fix #333
* 📝 update the behavior of geturl of zipfs and tarfs
* 👕 address review feedback
✨ url quote the files for proper url string
* 💚 fix broken tests
* ♿ add helpful exception info to help developers, who create pypifs, gitfs, fs.datalake et al. fix #340
* 🐛 fix windows path test
* ✨ uniformly support fs purpose
* 🔨 quote around the root path. #340
* 🚜 alternative file uri implementation
* 🔬 try windows path test case where unicode characters stays as they are
* 🐛 fix unit test expectation because of the difference between windows and linux file uri
* 🚜 avoid Windows File URI for fs purpose
* 🐛 before quote, utf8 string needs to be encoded. https://stackoverflow.com/questions/15115588/urllib-quote-throws-keyerror
* 🚜 respect rfc 3986, where unicode will be quoted
* 💚 🔨 code refactor and fix broken unit tests
* 👕 address review feedback from @lurch
* 💚 fix typo in code and 👕 update assertions
* 🔥 remove unused variable
* 👕 address further comments from @lurch
* 💚 update windows test case. fix the typo
* 🐛 colon:tmp is bad path under windows
* 🐛 forward slash on Windows is a valid path separator
* 💚 fix unit tests on travis-ci
* 👕 address review comments
* 👕 mypy compliance
* 👕 dot the i and cross the t
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
geturl()will returnfile://D:\a\1\s\tests\fixtures\template(the dog food) on windows, which can be not used(eaten) by osfs itself.an PR is coming to fix it. I am logging this issue here.
The text was updated successfully, but these errors were encountered: