Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow multiline comments in PullRequest #2540

Merged
merged 27 commits into from
Jun 15, 2023
Merged

Allow multiline comments in PullRequest #2540

merged 27 commits into from
Jun 15, 2023

Commits on May 31, 2023

  1. fix(PullRequest.create_comment): add multiline comment

    @heitorpolidoro
    heitorpolidoro committed May 31, 2023
    Configuration menu
    Copy the full SHA
    e3efd64 View commit details
    Browse the repository at this point in the history

  2. fix(PullRequest.create_comment): fix and create tests

    @heitorpolidoro
    heitorpolidoro committed May 31, 2023
    Configuration menu
    Copy the full SHA
    b4f6dae View commit details
    Browse the repository at this point in the history

  3. fix(PullRequest.create_comment): lint

    @heitorpolidoro
    heitorpolidoro committed May 31, 2023
    Configuration menu
    Copy the full SHA
    71ce75e View commit details
    Browse the repository at this point in the history

  4. fix(PullRequest.create_comment): lint

    @heitorpolidoro
    heitorpolidoro committed May 31, 2023
    Configuration menu
    Copy the full SHA
    84bd203 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Update github/PullRequest.py 

    Co-authored-by: Enrico Minack <github@enrico.minack.dev>
    @heitorpolidoro @EnricoMi
    heitorpolidoro and EnricoMi committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    d559f6d View commit details
    Browse the repository at this point in the history

  2. Update github/PullRequest.py 

    Co-authored-by: Enrico Minack <github@enrico.minack.dev>
    @heitorpolidoro @EnricoMi
    heitorpolidoro and EnricoMi committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    bd00108 View commit details
    Browse the repository at this point in the history

  3. Fix broken urls in docstrings (#2393)

    @Muscaw @heitorpolidoro
    Muscaw authored and heitorpolidoro committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    28eb82b View commit details
    Browse the repository at this point in the history

  4. Add name, display_title and path attributes to WorkflowRun (#… 

    …2397)
    @nuang-ee @heitorpolidoro
    nuang-ee authored and heitorpolidoro committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    1bc6179 View commit details
    Browse the repository at this point in the history

  5. Add name filter to Repository.get_artifacts() (#2459) 

    Co-authored-by: Enrico Minack <github@enrico.minack.dev>
    @trim21 @EnricoMi @heitorpolidoro
    2 people authored and heitorpolidoro committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    2d5933f View commit details
    Browse the repository at this point in the history

  6. Merging 1.58.x patch release notes into master (#2525) 

    Co-authored-by: Steve Kowalik <steven@wedontsleep.org>
    @EnricoMi @s-t-e-v-e-n-k @heitorpolidoro
    2 people authored and heitorpolidoro committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    f00b0be View commit details
    Browse the repository at this point in the history

  7. Add sort order and direction for getting comments (#2544) 

    Note: This is a breaking change. The order of parameters of `PullRequest.get_review_comments` has changed to match other `get_comments` methods and Github API parameter order. Users should change `PullRequest.get_review_comments(since)` to `PullRequest.get_review_comments(since=since)`.

Calling without parameter is not breaking: `PullRequest.get_review_comments()`
    @EnricoMi @heitorpolidoro
    EnricoMi authored and heitorpolidoro committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    fe2525a View commit details
    Browse the repository at this point in the history

  8. Add authentication classes, move auth logic there (#2528) 

    This adds argument `auth` and deprecates `login_or_token`, `password`, `jwt`, and `app_auth` arguments of `github.Github`.

This adds argument `auth` and deprecates `integration_id`, `private_key` of `github.GithubIntegration`.

This deprecates the `create_jwt` method of `github.GithubIntegration`, replaced by `github.Auth.AppAuth.create_jwt`.
    @EnricoMi @heitorpolidoro
    EnricoMi authored and heitorpolidoro committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    8b27cc5 View commit details
    Browse the repository at this point in the history

  9. Make MainClass.get_app return completed GithubApp when slug is gi… 

    …ven (#2543)

Fixes slug attribute to fetch app when not set. Loads app with slug lazily, fetch complete app without slug.
    @EnricoMi @heitorpolidoro
    EnricoMi authored and heitorpolidoro committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    14e902e View commit details
    Browse the repository at this point in the history

  10. Add support for new RepositoryAdvisories API 🎉 (#2483)

    @JLLeitschuh @heitorpolidoro
    JLLeitschuh authored and heitorpolidoro committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    cb13705 View commit details
    Browse the repository at this point in the history

  11. Fix auth issues with Installation.get_repos (#2547)

    @EnricoMi @heitorpolidoro
    EnricoMi authored and heitorpolidoro committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    1e16ae0 View commit details
    Browse the repository at this point in the history

  12. Make Requester.__createException robust against missing message and b… 

    …ody (#2159)
    @EnricoMi @heitorpolidoro
    EnricoMi authored and heitorpolidoro committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    6a41b40 View commit details
    Browse the repository at this point in the history

  13. Add support for environments (#2223)

    @alson @heitorpolidoro
    alson authored and heitorpolidoro committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    cc6a627 View commit details
    Browse the repository at this point in the history

  14. Implement AppUserAuth for Github App user tokens (#2546) 

    Allows to refresh Github App user token. Integrates `ApplicationOAuth` into `github.Auth`.
    @EnricoMi @heitorpolidoro
    EnricoMi authored and heitorpolidoro committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    c504fb8 View commit details
    Browse the repository at this point in the history

  15. feat(PullRequest.create_review_comment): new parameters and better te… 

    …st for 'as_suggestion'
    @heitorpolidoro
    heitorpolidoro committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    41c79dd View commit details
    Browse the repository at this point in the history

  16. Merge branch 'master' into fix_create_comment_issues

    @heitorpolidoro
    heitorpolidoro committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    7543301 View commit details
    Browse the repository at this point in the history

  17. style(PullRequest.create_review_comment): fixing lint errors

    @heitorpolidoro
    heitorpolidoro committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    18a9e57 View commit details
    Browse the repository at this point in the history

  18. Merge branch 'master' into fix_create_comment_issues

    @heitorpolidoro
    heitorpolidoro committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    69f85a3 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. Update github/PullRequest.py 

    fix(PullRequest.create_review_comment): Change default from None to NotSet

Co-authored-by: Enrico Minack <github@enrico.minack.dev>
    @heitorpolidoro @EnricoMi
    heitorpolidoro and EnricoMi committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    7feb50c View commit details
    Browse the repository at this point in the history

  2. fix(PullRequest.create_review_comment): Change default from None to N… 

    …otSet

Co-authored-by: Enrico Minack <github@enrico.minack.dev>
    @heitorpolidoro @EnricoMi
    heitorpolidoro and EnricoMi committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    10254c2 View commit details
    Browse the repository at this point in the history

  3. fix(PullRequest.create_review_comment): Change default from None to N… … 

    …10254c2 …otSet

Co-authored-by: Enrico Minack <github@enrico.minack.dev>
    @heitorpolidoro @EnricoMi
    heitorpolidoro and EnricoMi committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    f9196de View commit details
    Browse the repository at this point in the history

  4. style(PullRequest.create_review_comment): minor changes

    @heitorpolidoro
    heitorpolidoro committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    6453e32 View commit details
    Browse the repository at this point in the history

  5. style(PullRequest.create_review_comment): lint

    @heitorpolidoro
    heitorpolidoro committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    50f5398 View commit details
    Browse the repository at this point in the history