Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements to WebcamVideoStream (VideoCapture Properties and Release) #177

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

karjanme
Copy link

@karjanme karjanme commented Feb 3, 2020

Address a few limitations with WebcamVideoStream:

1.) Set resolution of the VideoCapture, or use a capture object with custom properties already set.
Based on feedback provided in #68 , the constructor has been improved to allow optional args for a VideoCapture object and a resolution tuple.
#68 (comment)

2.) Address #35 by releasing the VideoCapture when the WebcamVideoStream is stopped.

Thank you for the time you've already spent developing this awesome library.

@karjanme
Copy link
Author

@jrosebr1 Please consider this PR when you have time. Let me know if you have any feedback on it. Thank you!

@makew0rld
Copy link

Not the maintainer, but thanks for this! I would suggest default setting the resolution to something like (10000, 10000), as this will force OpenCV to use the highest possible resolution of the camera, which it doesn't do by default.

@karjanme
Copy link
Author

Not the maintainer, but thanks for this! I would suggest default setting the resolution to something like (10000, 10000), as this will force OpenCV to use the highest possible resolution of the camera, which it doesn't do by default.

@makeworld-the-better-one I like your idea, but I'll leave it up to the maintainer to decide how they want this to work. I defaulted the resolution here to (320, 240) because that is the default in the other existing classes VideoStream and PiVideoStream.

@makew0rld
Copy link

Thanks for the changes!

@karjanme
Copy link
Author

@ariG23498 please consider this PR to fix a couple issues that are frequently reported by other users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants