Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken wheels (macOS) #124

Closed
omerbenamram opened this issue May 4, 2019 · 3 comments
Closed

broken wheels (macOS) #124

omerbenamram opened this issue May 4, 2019 · 3 comments

Comments

@omerbenamram
Copy link
Contributor

Currently wheels produced with pyo3-pack are not working in macOS (maybe on other platforms as well?).

I initially though this is related to PyO3/pyo3#341, but I've tried reverting to pyo3 0.5.4 and the issue persisted.

I'm using the extension-module feature.

I'm getting the following error:

Python 3.7.3 | packaged by conda-forge | (default, Mar 27 2019, 15:43:19)
[Clang 4.0.1 (tags/RELEASE_401/final)] :: Anaconda, Inc. on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import evtx
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: dynamic module does not define module export function (PyInit_evtx)
>>>

And for wheels setuptools-rust with python setup.py bdist_wheel it's working as expected.

Python 3.7.3 | packaged by conda-forge | (default, Mar 27 2019, 15:43:19)
[Clang 4.0.1 (tags/RELEASE_401/final)] :: Anaconda, Inc. on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import evtx
>>>

All the code is public at https://github.com/omerbenamram/pyevtx-rs

Any thoughts?

@konstin
Copy link
Member

konstin commented May 4, 2019

Sounds like a naming mismatch. Try renaming https://github.com/omerbenamram/pyevtx-rs/blob/master/src/lib.rs#L115 from parser to evtx

@omerbenamram
Copy link
Contributor Author

omerbenamram commented May 4, 2019

@konstin It works!

If there's any way it could have warned me against this (I'm not sure it's possible) that would have been awesome! Thanks again for this great tool :)

konstin added a commit that referenced this issue May 12, 2019
Warn about missing PyInit function to fix #124
@messense
Copy link
Member

messense commented May 7, 2021

#528 added missing PyInit_<module_name> symbol export warning for macOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants