Deprecate --universal2 in favor of universal2-apple-darwin target
#1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for maturin-guide ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
messense
force-pushed
the
universal2-apple-darwin
branch
from
001c627
to
14ec8e3
Compare
messense
changed the title
--univeral2 instead of universal2-apple-darwin target--univeral2 in favor of universal2-apple-darwin target
messense
force-pushed
the
universal2-apple-darwin
branch
from
14ec8e3
to
990bd2b
Compare
bobzilladev
reviewed
Feb 22, 2023
There was a problem hiding this comment.
Noticed these, wanted to double check if the actually-checked value was ok (it is), but thought I should point em out.
Also seeing this in the action, but maybe that hasn't been updated yet:
Error: error: Error loading target specification: Could not find specification for target "universal2-apple-darwin". Run
rustc --print target-listfor a list of built-in targets
at installRustTarget (/Users/runner/work/_actions/PyO3/maturin-action/v1/dist/index.js:11795:15)
at async hostBuild (/Users/runner/work/_actions/PyO3/maturin-action/v1/dist/index.js:11841:5)
at async innerMain (/Users/runner/work/_actions/PyO3/maturin-action/v1/dist/index.js:11966:20)
at async main (/Users/runner/work/_actions/PyO3/maturin-action/v1/dist/index.js:11974:9)
| @@ -509,6 +509,12 @@ impl BuildOptions { | |||
| let mut target_triple = self.target.clone(); | |||
|
|
|||
| let mut universal2 = self.universal2; | |||
| if universal2 { | |||
| eprintln!("⚠️ Warning: `--universal2` is deprecated, use `--target univeral2-apple-darwin` instead"); | |||
There was a problem hiding this comment.
nit: "univeral2-apple-darwin" is missing an s
| @@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| * Add Cargo compile targets configuration for filtering multiple bin targets in [#1339](https://github.com/PyO3/maturin/pull/1339) | |||
| * Respect `rustflags` settings in cargo configuration file in [#1405](https://github.com/PyO3/maturin/pull/1405) | |||
| * Bump MSRV to 1.63.0 in [#1407](https://github.com/PyO3/maturin/pull/1407) | |||
| * Deprecate `--univeral2` in favor of `universal2-apple-darwin` target in [#1457](https://github.com/PyO3/maturin/pull/1457) | |||
|
Fixed in 11b0cca, thanks @bobzilladev |
messense
changed the title
--univeral2 in favor of universal2-apple-darwin target--universal2 in favor of universal2-apple-darwin target
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Mar 19, 2023
https://build.opensuse.org/request/show/1072766 by user mia + dimstar_suse - Update to v0.14.15: * Add sdist and sccache support to generate-ci command - Changes in v0.14.14: * Add support for Emscripten in generate-ci command gh#PyO3/maturin#1484 * Use default ext_suffix for Emscripten target if not provided in PYO3_CONFIG_FILE gh#PyO3/maturin#1491 * Deprecate package.metadata.maturin.data in favor of tool.maturin.data in pyproject.toml gh#PyO3/maturin#1492 - Update to v0.14.13: * maturin develop now looks for a virtualenv .venv in the current or any parent directory if no virtual environment is active gh#PyO3/maturin#1462 * Add a new generate-ci command to generate CI configuration gh#PyO3/maturin#1456 * Deprecate --univeral2 in favor of universal2-apple-darwin target gh#PyO3/maturin#1457 * Raise an error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the command line options less special for macOS, will remove
--universal2in 1.0.