Detect target based on interpreter for pep517 build-wheel #2086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for maturin-guide ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
kcking
force-pushed
the
main
branch
3 times, most recently
from
59b8474
to
48c9ef2
Compare
Revert "Detect target based on interpreter for pep517 build-wheel" This reverts commit 88bce88.
|
Thanks for the PR, consider reopen it regardless of the CI issue, it's a known issue/bug of virualenv on Windows that occurs from time to time. |
|
Ah gotcha, thanks! Re-created as #2088 since I wasn't able to reopen this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR detects the desired target based on the python interpreter for pep517 commands, similar to the detection already in place for
maturin develop.This fixes
maturin pep517 build-wheelbuilding for the host architecture, even when the current python interpreter is a different architecture, ie. when using an x86_64 python on arm64 macos host.Related issue: #2041