Make PEP 517 build wheel defaults to linux compatibility #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for maturin-guide ready! 🔨 Explore the source changes: 7a9b3fd 🔍 Inspect the deploy log: https://app.netlify.com/sites/maturin-guide/deploys/621c85a1936a67000845e69b 😎 Browse the preview: https://deploy-preview-823--maturin-guide.netlify.app |
messense
force-pushed
the
pep517-linux
branch
from
afd6b19
to
ac6fc3b
Compare
davidhewitt
reviewed
Feb 28, 2022
|
I think I agree; if a user is building via |
messense
force-pushed
the
pep517-linux
branch
from
ac6fc3b
to
7a9b3fd
Compare
davidhewitt
approved these changes
Feb 28, 2022
konstin
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think pep517 build process needs to ensure manylinux/musllinux compatibility, correct me if I'm wrong.