Add hardcoded well-known sysconfigs for effortless cross compiling #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for maturin-guide ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
davidhewitt
reviewed
May 4, 2022
| version={major}.{minor} | ||
| shared=true | ||
| abi3=false | ||
| build_flags=WITH_THREAD |
There was a problem hiding this comment.
Nb I think this flag only necessary on Python older than 3.7
| } | ||
| } | ||
|
|
||
| let mut interpreters = Vec::new(); | ||
| if binding_name.starts_with("pyo3") && target.is_unix() && target.cross_compiling() { | ||
| if let Some(cross_lib_dir) = std::env::var_os("PYO3_CROSS_LIB_DIR") { |
There was a problem hiding this comment.
Should there also be a check for PYO3_CONFIG_FILE env var, and just skip all this if so?
There was a problem hiding this comment.
I think that'd be nice, but it's out of scope of this PR, I'll open a new issue to track it.
messense
force-pushed
the
well-known-sysconfig
branch
from
7566a0d
to
5f67d9a
Compare
messense
changed the title
messense
changed the title
messense
force-pushed
the
well-known-sysconfig
branch
from
5f67d9a
to
205b3dd
Compare
konstin
approved these changes
May 4, 2022
Yes, that's the goal of this. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #756 (comment)
With this when cross compiling for non-abi3 Linux wheels, there is no need to supply
PYO3_CROSS_LIB_DIRanymore and-i pythonX.Ywill just work™️. Internally maturin generates a pyo3 config file based on collected sysconfigs and setPYO3_CONFIG_FILEenv var for pyo3's build script.In theory we can extend the support to most Unix systems,
for example macOS(added macOS in this PR generated from https://github.com/messense/python-sysconfig-collector), but that can be done in its dedicated PRs.