Add --find-interpreter option to build and publish commands
#964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for maturin-guide ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
messense
commented
Jun 10, 2022
messense
added
the
CI-no-fail-fast
messense
force-pushed
the
find-interpreter
branch
2 times, most recently
from
2ded590
to
87d5102
Compare
messense
removed
the
CI-no-fail-fast
messense
force-pushed
the
find-interpreter
branch
2 times, most recently
from
68b13cd
to
3bd126a
Compare
messense
force-pushed
the
find-interpreter
branch
from
3bd126a
to
7162269
Compare
Some behaviors changed: 1. `maturin build` now implicitly translate to `maturin build -i python3`, meaning that we only build for the current python3 interpreter in `PATH` 2. `maturin build --find-interpreter` makes maturin search for interpreters on host, also search for bundled sysconfig when cross compiling 3. Mix `-i` and `--find-interpreter` is not allowed 4. `maturin publish` does the same as `maturin build`
messense
force-pushed
the
find-interpreter
branch
from
7162269
to
2b47d13
Compare
Closed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some behaviors changed:
maturin buildnow implicitly translate tomaturin build -i python3, meaning that we only build for the current python3 interpreter inPATHmaturin build --find-interpretermakes maturin search for interpreters on host, also search for bundled sysconfig when cross compiling-iand--find-interpreteris not allowedmaturin publishdoes the same asmaturin buildPart of #796