Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --find-interpreter option to build and publish commands #964

Merged
merged 1 commit into from
Jun 11, 2022

Conversation

messense
Copy link
Member

Some behaviors changed:

  1. maturin build now implicitly translate to maturin build -i python3, meaning that we only build for the current python3 interpreter in PATH
  2. maturin build --find-interpreter makes maturin search for interpreters on host, also search for bundled sysconfig when cross compiling
  3. Mix -i and --find-interpreter is not allowed
  4. maturin publish does the same as maturin build

Part of #796

@netlify
Copy link

netlify bot commented Jun 10, 2022

Deploy Preview for maturin-guide ready!

Name Link
🔨 Latest commit 2b47d13
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/62a4ad359b87fb00085b85c1
😎 Deploy Preview https://deploy-preview-964--maturin-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@messense messense mentioned this pull request Jun 10, 2022
6 tasks
src/build_options.rs Outdated Show resolved Hide resolved
@messense messense added the CI-no-fail-fast If one job fails, allow the rest to keep testing label Jun 10, 2022
@messense messense force-pushed the find-interpreter branch 2 times, most recently from 2ded590 to 87d5102 Compare June 11, 2022 01:46
@messense messense removed the CI-no-fail-fast If one job fails, allow the rest to keep testing label Jun 11, 2022
@messense messense requested a review from konstin June 11, 2022 02:08
@messense messense marked this pull request as ready for review June 11, 2022 02:09
@messense messense force-pushed the find-interpreter branch 2 times, most recently from 68b13cd to 3bd126a Compare June 11, 2022 11:41
Copy link
Member

@konstin konstin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/build_options.rs Outdated Show resolved Hide resolved
Some behaviors changed:

1. `maturin build` now implicitly translate to `maturin build -i python3`, meaning that we only build for the current python3 interpreter in `PATH`
2. `maturin build --find-interpreter` makes maturin search for interpreters on host, also search for bundled sysconfig when cross compiling
3. Mix `-i` and `--find-interpreter` is not allowed
4. `maturin publish` does the same as `maturin build`
@messense messense merged commit 0fdae5a into PyO3:main Jun 11, 2022
@messense messense deleted the find-interpreter branch June 11, 2022 14:57
@messense messense linked an issue Jun 11, 2022 that may be closed by this pull request
6 tasks
@messense messense removed a link to an issue Oct 10, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants