ffi cleanup: object.h #1429
Merged
ffi cleanup: object.h #1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
approved these changes
Feb 14, 2021
src/ffi/cpython/object.rs
Outdated
Comment on lines
371
to
383
| #[cfg(py_sys_config = "COUNT_ALLOCS")] | ||
| #[deprecated(note = "not present in Python headers; to be removed")] | ||
| pub const PyTypeObject_INIT: PyTypeObject = type_object_init! { | ||
| tp_allocs: 0, | ||
| tp_frees: 0, | ||
| tp_maxalloc: 0, | ||
| tp_prev: ptr::null_mut(), | ||
| tp_next: ptr::null_mut(), | ||
| }; | ||
|
|
||
| #[cfg(not(py_sys_config = "COUNT_ALLOCS"))] | ||
| #[deprecated(note = "not present in Python headers; to be removed")] | ||
| pub const PyTypeObject_INIT: PyTypeObject = type_object_init!(); |
There was a problem hiding this comment.
TBH I think this falls under the same bracket of the other _INIT constants which aren't actually defined upstream; we can just throw it away for the 0.14 release. Nobody should be using it.
Looks like that would allow quite a lot of macro code above to be deleted too!
There was a problem hiding this comment.
I thought so, but didn't want to presume. Updated.
Shall we also remove PyObject_Check, PySuper_Check, and FreeFunc? They're not in the Python API either, and I struggle to imagine why, for example, a downstream user would need need a function to verify that a PyObject is a Python object (always returns 1).
There was a problem hiding this comment.
Agreed that we can remove those three too!
This should only be used internally. See discussion: PyO3#1429 (comment)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one's a fairly big change to account for the new
cpython/object.hfile.Deprecate some FFI definitions which are not in the API
freefuncwhich is subtly different -- fixed_PyEval_RequestCodeExtraIndex, which takes afreefuncas an argument)I thought the INCREF, DECREF, ... methods were a bit off.
See review (soon).EDIT:will open new issuethis is fine