pymodule: tidy up module init #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
messense
reviewed
May 25, 2021
src/derive_utils.rs
Outdated
| @@ -312,14 +321,8 @@ impl ModuleDef { | |||
| #[cfg(not(Py_3_7))] | |||
| ffi::PyEval_InitThreads(); | |||
There was a problem hiding this comment.
Actually I don't think this call to PyEval_InitThreads is needed at all. Pushed a commit to remove it, and updated the OP.
davidhewitt
force-pushed
the
module-init
branch
2 times, most recently
from
85092f0
to
3e87ea3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three small tweaks:
PyModuleDef_INITsymbol.__doc__viam_docdef member rather than with asetattr()call.ffi::PyEval_InitThreads()- as far as I can tell this isn't necessary (even on Python 3.6).