packaging: formal support for Python 3.10 #1889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
py310
branch
2 times, most recently
from
f68a341
to
cefeabd
Compare
davidhewitt
commented
Sep 26, 2021
Co-authored-by: Bruno Kolenbrander <59372212+mejrs@users.noreply.github.com>
mejrs
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR goes through the FFI changes listed in #1781, and also adds an
abi3-py310feature.Given that we have also tested Python 3.10 on CI for a long time, and this PR adds the documented C API changes, I think we can call Python 3.10 officially supported now.
I also made a tidy-up pass to use
_Py_NewRefin expressions in a bunch of places, because imo it's nicer than callingPy_INCREFin a separate satement. And we can define_Py_NewRefon all supported Python versions (not just 3.10).Closes #1781
(The PEP 622 support is tracked separately in #1714 - I don't think we'll have this ready by the time 3.10 is released.)