refactor: inline handle_panic into macro output #2158
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking at
cargo llvm-lines
output one last time, and a major contributor to llvm line count seems to bepyo3::callback::handle_panic
.Because it takes the whole function body as a closure, it's going to be instantiated separately for each pyfunction. Inlining it into the macro outputs leads to about a 10% reduction in llvm line counts for the
pytests
crate.cd pytests; cargo llvm-lines | head -n 10
on main:On this branch: