Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conversions between Rust Path/PathBuf and Python str / pathlib.Path #3272

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

lucatrv
Copy link
Contributor

@lucatrv lucatrv commented Jun 25, 2023

Thank you for contributing to PyO3!

By submitting these contributions you agree for them to be licensed under PyO3's Apache-2.0 license.

PyO3 is currently undergoing a relicensing process to match Rust's dual-license under Apache-2.0 and MIT licenses. While that process is ongoing, if you are a first-time contributor please add your agreement as a comment in #3108.

Please consider adding the following to your pull request:

  • an entry for this PR in newsfragments - see [https://pyo3.rs/main/contributing.html#documenting-changes]
  • docs to all new functions and / or detail in the guide
  • tests for all new or changed functions

PyO3's CI pipeline will check your pull request. To run its tests
locally, you can run cargo xtask ci. See its documentation
here.

Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@davidhewitt davidhewitt added the CI-skip-changelog Skip checking changelog entry label Jun 26, 2023
@davidhewitt davidhewitt added this pull request to the merge queue Jun 26, 2023
Merged via the queue into PyO3:main with commit 76b794a Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants