Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PyList.reverse(). #358

Merged
merged 1 commit into from
Feb 18, 2019
Merged

Add PyList.reverse(). #358

merged 1 commit into from
Feb 18, 2019

Conversation

chr1sj0nes
Copy link
Contributor

No description provided.

kngwyu
kngwyu approved these changes Feb 17, 2019
View reviewed changes
Copy link
Member

@kngwyu kngwyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kngwyu
Copy link
Member

kngwyu commented Feb 17, 2019

Thanks!
Looks it conflicts with your previous PR.
Could you please rebase on the latest master?
I'm on the train now and can't do that for a while.

@chr1sj0nes
Copy link
Contributor Author

Rebased. Thanks.

@kngwyu
Copy link
Member

kngwyu commented Feb 18, 2019

Thanks!

@kngwyu kngwyu merged commit f248aad into PyO3:master Feb 18, 2019
@chr1sj0nes chr1sj0nes deleted the pylist_reverse branch March 5, 2019 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kngwyu kngwyu kngwyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chr1sj0nes @kngwyu