Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose coroutine constructor #3613

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

wyfo
Copy link
Contributor

@wyfo wyfo commented Nov 30, 2023

Relates to #1632

Draft based on #3612

This should be the final PR of the async support! 🥳

@wyfo wyfo marked this pull request as draft November 30, 2023 15:48
Copy link

codspeed-hq bot commented Nov 30, 2023

CodSpeed Performance Report

Merging #3613 will not alter performance

Comparing wyfo:coroutine_new (7a17c5e) with main (6c2e6f8)

Summary

✅ 67 untouched benchmarks

Asyncio is the standard and de facto main Python async runtime.
Among non-standard runtime, only trio seems to have substantial traction,
especially thanks to the anyio project.
There is indeed a strong trend for anyio (e.g. FastApi), which can
justify a dedicated support.
@Distortedlogic
Copy link

when merge?

@LilyFoote
Copy link
Contributor

For this to be merged it'll need the merge conflicts fixed and the tests passing.

@davidhewitt
Copy link
Member

Primarily it's blocked on #3610, but we need to make a decision on that in combination with #3646.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants