move downcast functions from PyAnyMethods to Bound<T>
#3988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
bound-downcast
branch
from
1238547
to
7801b7d
Compare
| @@ -96,6 +96,221 @@ where | |||
| } | |||
| } | |||
|
|
|||
| impl<'py, T> Bound<'py, T> { | |||
| /// Downcast this `PyAny` to a concrete Python type or pyclass. | |||
There was a problem hiding this comment.
The wording seems incorrect now that the receiver is Bound<T> instead of &PyAny or even Bound<PyAny>?
There was a problem hiding this comment.
Maybe "Downcast this Python value to a subtype"?
There was a problem hiding this comment.
As a second thought, it's not just about "downcasting" any more, as U might be a supertype of T. Would it be better to call these APIs .cast() instead of .downcast()?
(That would be a solution to avoid needing to remove the PyAnyMethods.)
I quite like .cast() though that might be a good reason to also leave this API until 0.22 and make it a more deliberate & documented addition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3980
There's quite a few cases of churn where moving these methods removed the need to
use PyAnyMethodsaround the codebase.Possibly a less aggressive form of this would be to leave the existing implementations on
PyAnyMethodsand just make these new methods forward toPyAnyMethods. I'm not sure there's a good reason to duplicate the API, though, so this seems a bit cleaner.