Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature gate deprecated APIs for PyFloat and PyComplex #4145

Merged
merged 1 commit into from
May 1, 2024
Merged

feature gate deprecated APIs for PyFloat and PyComplex #4145

merged 1 commit into from
May 1, 2024

Conversation

Icxolu
Copy link
Contributor

@Icxolu Icxolu commented May 1, 2024

Part of #3960

Move deprecated PyFloat and PyComplex behind gil-refs features gate.

@Icxolu Icxolu added the CI-skip-changelog Skip checking changelog entry label May 1, 2024
@Icxolu Icxolu mentioned this pull request May 1, 2024
Closed
51 tasks
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented May 1, 2024

CodSpeed Performance Report

Merging #4145 will improve performances by 10.33%

Comparing Icxolu:numeric (5a590e4) with main (5534a7b)

Summary

⚡ 1 improvements
✅ 68 untouched benchmarks

Benchmarks breakdown

Benchmark main Icxolu:numeric Change
⚡ sequence_from_tuple 296.7 ns 268.9 ns +10.33%

@LilyFoote LilyFoote added this pull request to the merge queue May 1, 2024
Merged via the queue into PyO3:main with commit a454f6e May 1, 2024
42 of 44 checks passed
@Icxolu Icxolu deleted the numeric branch May 1, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilyFoote LilyFoote LilyFoote approved these changes

Assignees
No one assigned
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Icxolu @LilyFoote