add benchmark for deferred object drops #4179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| fn criterion_benchmark(c: &mut Criterion) { | ||
| c.bench_function("drop_many_objects", drop_many_objects); | ||
| c.bench_function("deferred_drop_many_objects", deferred_drop_many_objects); |
There was a problem hiding this comment.
This is not an argument against adding this benchmark, but I fear we will need a multi-threaded benchmark to really measure the coherence traffic effects. This will be painful to do as a microbenchmark, but I fear we will be missing the larger picture without it.
There was a problem hiding this comment.
Agreed, we will probably need a couple of multi threaded benchmarks to model different usage patterns. In the end I had less time today than I was hoping, but I might be able to do some tomorrow.
|
Closing as I think we superseded this with benchmarks added in #4178 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing #4174 and #4178, I thought this benchmark will be helpful.