Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: minor cleanups following 1.63 MSRV #4239

Merged
merged 4 commits into from
Jun 21, 2024

Conversation

davidhewitt
Copy link
Member

@davidhewitt davidhewitt commented Jun 7, 2024

Found some stray TODOs following #4129

Mostly this came down to accepting that the multiple-pymethods feature will continue to be a separate build mode because of lack of wider platform support, so I cleaned up CI a bit to deal with that.

Also, it looks like the chrono TODO no longer applies and they reversed / cleaned up their deprecation.

@davidhewitt davidhewitt added the CI-skip-changelog Skip checking changelog entry label Jun 7, 2024
@davidhewitt
Copy link
Member Author

Hmm, will check whatever I've managed to do to CI later...

@davidhewitt davidhewitt marked this pull request as draft June 7, 2024 16:08
@davidhewitt davidhewitt marked this pull request as ready for review June 18, 2024 07:16
@davidhewitt
Copy link
Member Author

If nobody has any concerns I will probably merge this tonight as a simple tidy up.

@davidhewitt davidhewitt added this pull request to the merge queue Jun 21, 2024
Merged via the queue into PyO3:main with commit ca82681 Jun 21, 2024
41 checks passed
@davidhewitt davidhewitt deleted the dh/ci-cleanups branch June 21, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants