Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve deprecation message on implicit trailing optionals #4282

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

davidhewitt
Copy link
Member

Testing out 0.22 release branch in pydantic-core, I noticed that the error message here generates hints like

Add `#[pyo3(signature = (error_type, context=None)]` to this function to silence this warning

which is missing a closing ).

I also decided to split the message up into multiple lines.

... I'll merge this as a trivial adjustment and rebase the release on it.

@davidhewitt davidhewitt added the CI-skip-changelog Skip checking changelog entry label Jun 24, 2024
@davidhewitt davidhewitt added this pull request to the merge queue Jun 24, 2024
Merged via the queue into PyO3:main with commit 91d8683 Jun 24, 2024
42 checks passed
@davidhewitt davidhewitt deleted the implicit-defaults-msg branch June 24, 2024 14:27
@davidhewitt davidhewitt mentioned this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants