Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ui tests #4397

Merged
merged 1 commit into from
Jul 30, 2024
Merged

fix ui tests #4397

merged 1 commit into from
Jul 30, 2024

Conversation

Icxolu
Copy link
Contributor

@Icxolu Icxolu commented Jul 30, 2024

Fix ui tests failures. These seem to depend on the locked versions. I only started seeing them after a cargo update.

Closes #4395

@Icxolu Icxolu added the CI-skip-changelog Skip checking changelog entry label Jul 30, 2024
@Icxolu
Copy link
Contributor Author

Icxolu commented Jul 30, 2024

Not sure why coverage failed now with the opposite error...

@davidhewitt
Copy link
Member

Probably related to features? I have a feeling what's happened is that when the full feature is on the zerocopy dependency is pulled in and affecting output. Potentially need to gate these tests on feature = "full" in some form.

@Icxolu
Copy link
Contributor Author

Icxolu commented Jul 30, 2024

I think you're right, let's give another go

@LilyFoote LilyFoote added this pull request to the merge queue Jul 30, 2024
Merged via the queue into PyO3:main with commit a5dd124 Jul 30, 2024
42 checks passed
@Icxolu Icxolu deleted the fix/ui-tests branch July 31, 2024 07:41
davidhewitt pushed a commit that referenced this pull request Sep 13, 2024
davidhewitt pushed a commit that referenced this pull request Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests failing on rust 1.80.0
3 participants