Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce constructors for PyByteArray, PyComplex, PyFloat, PyEllipsis, PyFrozenSet #4409

Merged
merged 5 commits into from
Aug 1, 2024

Conversation

bschoenmaeckers
Copy link
Contributor

I updated the constructors for PyByteArray, PyComplex, PyFloat, PyEllipsis, PyFrozenSet. To make it issuer to review I combined the commits into this one PR to let it merge in one go. If you still want to split it into different PR's please let me know!.

@bschoenmaeckers bschoenmaeckers force-pushed the combined_new_constructors branch 2 times, most recently from eeb81bb to 36d0177 Compare August 1, 2024 20:57
Copy link
Contributor

@Icxolu Icxolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, some small adjustments needed for FrozenSet, otherwise looks good 🚀

src/types/frozenset.rs Outdated Show resolved Hide resolved
@Icxolu Icxolu added the CI-skip-changelog Skip checking changelog entry label Aug 1, 2024
@Icxolu Icxolu enabled auto-merge August 1, 2024 21:21
@Icxolu Icxolu added this pull request to the merge queue Aug 1, 2024
Merged via the queue into PyO3:main with commit 2ee7c32 Aug 1, 2024
40 of 43 checks passed
@bschoenmaeckers bschoenmaeckers deleted the combined_new_constructors branch August 9, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants