Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PyModule::dict #809

Merged
merged 1 commit into from
Mar 16, 2020
Merged

Fix PyModule::dict #809

merged 1 commit into from
Mar 16, 2020

Conversation

kngwyu
Copy link
Member

@kngwyu kngwyu commented Mar 16, 2020

Here from_owned_ptr is used, which decrements refcnt invalidly and can cause segfault.

@davidhewitt
Copy link
Member

👍 good catch

@kngwyu kngwyu merged commit d4281a0 into PyO3:master Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants