Unify PyMethodsInventoryDispatch and PyMethodsProtocol #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
approved these changes
May 2, 2020
| @@ -213,7 +213,7 @@ fn parse_descriptors(item: &mut syn::Field) -> syn::Result<Vec<FnType>> { | |||
| fn impl_inventory(cls: &syn::Ident) -> TokenStream { | |||
| // Try to build a unique type that gives a hint about it's function when | |||
| // it comes up in error messages | |||
| let name = cls.to_string() + "GeneratedPyo3Inventory"; | |||
| let name = format!("Pyo3MethodsInventoryFor{}", cls); | |||
There was a problem hiding this comment.
Suggested change
| let name = format!("Pyo3MethodsInventoryFor{}", cls); | |
| let name = format!("PyMethodsOf{}", cls); |
Longer name is also fine, just wondered if I could find a shorter one which worked.
There was a problem hiding this comment.
Since this is a generated struct, I think it's better if a user can understand that this is generated from the name if he or she uses cargo expand.
There was a problem hiding this comment.
That's fair. PyO3GeneratedMethodsFor{} ? Your choice of name is also fine.
src/class/methods.rs
Outdated
Comment on lines
128
to
129
| #[doc(hidden)] // Only to be used through the proc macros | ||
| /// For pyclass derived structs, this trait collects method from all impl blocks using inventory. |
There was a problem hiding this comment.
Usually I put attributes after doc? Maybe it doesn't work for #[doc(hidden)]
Suggested change
| #[doc(hidden)] // Only to be used through the proc macros | |
| /// For pyclass derived structs, this trait collects method from all impl blocks using inventory. | |
| /// For pyclass derived structs, this trait collects method from all impl blocks using inventory. | |
| #[doc(hidden)] // Only to be used through the proc macros |
|
We probably need a |
kngwyu
added a commit
to kngwyu/pyo3
that referenced
this pull request
May 11, 2020
kngwyu
added a commit
to kngwyu/pyo3
that referenced
this pull request
May 11, 2020
kngwyu
added a commit
that referenced
this pull request
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyMethodProtocolis exposed as a public API, but it is actually really difficult to use without proc-macro.So I decided to unify
PyMethodsInventoryDispatchandPyMethodsProtocol, yieldingPyMethodsImpl.Since we need more inventory-related types to remove specialization, I think we need this kind of simplification not to make our code too complex.