Add accessor methods to PyByteArray
#967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
bytearray-as-bytes
branch
2 times, most recently
from
043e35c
to
b313d16
Compare
kngwyu
approved these changes
Jun 9, 2020
src/types/bytearray.rs
Outdated
| /// Get the contents of this buffer as a slice. | ||
| /// | ||
| /// # Safety | ||
| /// This is equivalent to `std::slice::from_raw_parts(self.data(), self.len())`, and so all |
There was a problem hiding this comment.
This document is well written, but could you please emphasize that we should not resize or delete the bytearray while holding the slice?
There was a problem hiding this comment.
Thanks, tweaked the doc slightly - what do you think of it now?
davidhewitt
force-pushed
the
bytearray-as-bytes
branch
from
b313d16
to
21d365f
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #632 .
This adds
PyByteArray::dataandPyByteArray::as_bytesas proposed in that issue.I decided to also add
as_bytes_mut, but if you think it's too far I can happily remove it. (Users can always implement themselves usingstd::slice::from_raw_parts_mut(b.data(), b.len()).)