Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate PyArray contructors to Bound API (Part 3) #419

Merged
merged 5 commits into from
Mar 28, 2024

Conversation

Icxolu
Copy link
Contributor

@Icxolu Icxolu commented Mar 25, 2024

Following #418

This finalizes the migration of PyArray constructors to the Bound API. This migrates with PyArray::{from_iter, from_array, from_vec}, alongside with IntoPyArray and ToPyArrray which they use under the hood. I think with this all constructors should be migrated.

@Icxolu Icxolu force-pushed the constructors-3 branch 3 times, most recently from 7dd1d4d to de69ccc Compare March 25, 2024 21:44
@maffoo
Copy link
Contributor

maffoo commented Mar 28, 2024

Out of curiosity, is this the last change needed before it would be possible to make a release compatible with pyo3 0.21? Is there any timeline for such a release?

@Icxolu
Copy link
Contributor Author

Icxolu commented Mar 28, 2024

There is still 2 or 3 PRs left to migrate everything:

  • disable pyo3s gil-ref feature
  • convert inner, dot and einsum
  • convert pyarray! macro

I can't say anything on a release schedule. Depending on the project you need this for, you could also try using cargo's patch to build against main in the meantime and see if everything works for you.

@adamreichold
Copy link
Member

adamreichold commented Mar 28, 2024

Depending on the project you need this for, you could also try using cargo's patch to build against main in the meantime and see if everything works for you.

I think we are still on the beta version and I am not completely sure whether Cargo will unify this with a dependency on the release version.

src/array.rs Outdated Show resolved Hide resolved
tests/to_py.rs Outdated Show resolved Hide resolved
Copy link
Member

@adamreichold adamreichold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for cosmetics.

Please also bump the dependency to the final version of PyO3 0.21 while fixing those up.

@adamreichold adamreichold merged commit 30f66f4 into PyO3:main Mar 28, 2024
33 of 35 checks passed
@Icxolu Icxolu deleted the constructors-3 branch March 28, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants