Skip to content

Conversation

catalys1
Copy link
Contributor

@catalys1 catalys1 commented Nov 4, 2021

What does this PR do?

Part of #10312

Removes deprecated every_n_val_epochs argument from ModelCheckpoint constructor.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers!

@carmocca carmocca added this to the v1.6 milestone Nov 5, 2021
@carmocca carmocca added breaking change Includes a breaking change refactor checkpointing Related to checkpointing labels Nov 5, 2021
@carmocca carmocca enabled auto-merge (squash) November 5, 2021 04:30
@mergify mergify bot added the has conflicts label Nov 5, 2021
@mergify mergify bot added ready PRs ready to be merged has conflicts and removed has conflicts labels Nov 5, 2021
@mergify mergify bot removed the has conflicts label Nov 5, 2021
@carmocca carmocca merged commit 1c28f36 into Lightning-AI:master Nov 5, 2021
@catalys1 catalys1 deleted the feat/remove-every_n_val_epochs branch November 5, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change checkpointing Related to checkpointing ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants