Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StreamIndenter fix for blank lines #58

Merged
merged 3 commits into from
Jun 13, 2019
Merged

StreamIndenter fix for blank lines #58

merged 3 commits into from
Jun 13, 2019

Conversation

jsiirola
Copy link
Contributor

Fixes: N/A

Summary/Motivation:

This updates the StreamIndenter to rstrip the prefix when outputting blank lines. This prevents outputting spaces on otherwise blank lines.

Changes proposed in this PR:

  • rstrip the prefix when writing otherwise blank lines

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@jsiirola jsiirola requested a review from carldlaird June 13, 2019 03:01
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.007%) to 62.239% when pulling 5d08b09 on indenter-fix into a210d03 on master.

@coveralls
Copy link

coveralls commented Jun 13, 2019

Coverage Status

Coverage increased (+0.04%) to 62.285% when pulling d299060 on indenter-fix into a210d03 on master.

@codecov-io
Copy link

codecov-io commented Jun 13, 2019

Codecov Report

Merging #58 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
+ Coverage   63.09%   63.13%   +0.03%     
==========================================
  Files          87       87              
  Lines        8693     8702       +9     
==========================================
+ Hits         5485     5494       +9     
  Misses       3208     3208
Impacted Files Coverage Δ
pyutilib/misc/indent_io.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a210d03...d299060. Read the comment docs.

@jsiirola jsiirola merged commit fa6ce97 into master Jun 13, 2019
@blnicho blnicho deleted the indenter-fix branch June 13, 2019 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants