Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Python 3.8 compatibility issues #66

Merged
merged 6 commits into from
Nov 7, 2019
Merged

Resolve Python 3.8 compatibility issues #66

merged 6 commits into from
Nov 7, 2019

Conversation

jsiirola
Copy link
Contributor

@jsiirola jsiirola commented Nov 7, 2019

Fixes: #65

Summary/Motivation:

Python 3.8 is out and is inducing some changes to PyUtilib.

Changes proposed in this PR:

  • Adding 3.8 baselines
  • Resolving use of the (now removed) time.clock
  • minor syntax cleanup

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

Switch to using perf_counter when it is available, as time.clock has
been removed in Python 3.8.  Fixes #65 and fixes Pyomo/pyomo#1143.
 - Add Python 3.8 to the list of supported interpreters
 - Add Travis tests for python 3.7 and 3.8
 - Add Appveyor builds for python 3.4 and 3.7
@coveralls
Copy link

coveralls commented Nov 7, 2019

Coverage Status

Coverage increased (+0.3%) to 61.845% when pulling 33d7ec2 on py38-fixes into cde4bee on master.

@codecov-io
Copy link

codecov-io commented Nov 7, 2019

Codecov Report

Merging #66 into master will increase coverage by 0.25%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
+ Coverage   62.57%   62.83%   +0.25%     
==========================================
  Files          87       87              
  Lines        8749     8775      +26     
==========================================
+ Hits         5475     5514      +39     
+ Misses       3274     3261      -13
Impacted Files Coverage Δ
pyutilib/misc/timing.py 0% <0%> (ø) ⬆️
pyutilib/ply/ply.py 23.33% <0%> (ø) ⬆️
pyutilib/workflow/functor.py 97.51% <100%> (ø) ⬆️
pyutilib/subprocess/processmngr.py 60.34% <100%> (+0.11%) ⬆️
pyutilib/th/pyunit.py 47.45% <0%> (-0.49%) ⬇️
pyutilib/autotest/driver.py 72.8% <0%> (+0.1%) ⬆️
pyutilib/component/core/core.py 84.73% <0%> (+0.11%) ⬆️
pyutilib/misc/archivereader.py 82.01% <0%> (+0.39%) ⬆️
pyutilib/pyro/worker.py 15.18% <0%> (+0.42%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cde4bee...33d7ec2. Read the comment docs.

@blnicho blnicho merged commit 19a1f1a into master Nov 7, 2019
@blnicho blnicho deleted the py38-fixes branch November 7, 2019 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatibility with Python 3.8 (time.clock)
4 participants