Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to setup.py and setup.cfg #75

Merged
merged 1 commit into from
Jan 17, 2020
Merged

Conversation

mrmundt
Copy link
Contributor

@mrmundt mrmundt commented Dec 16, 2019

Fixes:

This PR removes an unnecessary _find_packages routine from the setup.py file.

Summary/Motivation:

We want to use the built-in capabilities of setuptools for packaging PyUtilib and include the LICENSE file when packaging (mostly for Conda distribution).

Changes proposed in this PR:

  • Remove _find_packages and replace with setuptools' find_packages
  • Include License file in setup.cfg (for Conda distribution)

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.08%) to 61.001% when pulling 388e7bc on mrmundt:setup_fixes into 5763915 on PyUtilib:master.

@codecov-io
Copy link

codecov-io commented Dec 16, 2019

Codecov Report

Merging #75 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #75   +/-   ##
=======================================
  Coverage   62.85%   62.85%           
=======================================
  Files          87       87           
  Lines        8777     8777           
=======================================
  Hits         5517     5517           
  Misses       3260     3260

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5763915...388e7bc. Read the comment docs.

@blnicho
Copy link
Contributor

blnicho commented Dec 17, 2019

Does this fix #72?

@jsiirola jsiirola merged commit 388e7bc into PyUtilib:master Jan 17, 2020
@mrmundt mrmundt deleted the setup_fixes branch January 17, 2020 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants