Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.4 requires PyYAML<=5.2 #78

Merged
merged 1 commit into from
Jan 17, 2020
Merged

Python 3.4 requires PyYAML<=5.2 #78

merged 1 commit into from
Jan 17, 2020

Conversation

jsiirola
Copy link
Contributor

Fixes: N/A

Summary/Motivation:

This works around a problem with the PyYAML distribution where PyPI doesn't recognize the PyYAML 'python_requires' directive from setup.py.

Changes proposed in this PR:

  • force PyYAML<=5.2 for Python 3.4 tests

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

This works around a problem with the PyYAML distribution where PyPI
doesn't recognize the PyYAML 'python_requires' directive from setup.py.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 61.055% when pulling 8485b2f on yaml-ver-fix into d37679f on master.

@jsiirola jsiirola merged commit 5964c9c into master Jan 17, 2020
@jsiirola jsiirola deleted the yaml-ver-fix branch January 17, 2020 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants