Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Py2 compatibility shim for assertRegex #83

Merged
merged 1 commit into from
Mar 13, 2020
Merged

Adding Py2 compatibility shim for assertRegex #83

merged 1 commit into from
Mar 13, 2020

Conversation

jsiirola
Copy link
Contributor

Fixes: #N/A

Summary/Motivation:

This adds a simple compatibility ship for assertRegex for Python 2/3 compatibility.

Changes proposed in this PR:

  • add assertRegex to pyutilib.th in Python 2

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.007%) to 61.032% when pulling 5781896 on jsiirola:py2py3-compat into 8f7dbe0 on PyUtilib:master.

@jsiirola jsiirola merged commit f49e95e into PyUtilib:master Mar 13, 2020
@jsiirola jsiirola deleted the py2py3-compat branch March 13, 2020 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blnicho blnicho blnicho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsiirola @coveralls @blnicho