Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of namespace packages in PyUtilib #85

Merged
merged 3 commits into from
Mar 16, 2020

Conversation

jsiirola
Copy link
Contributor

Fixes: #N/A

Summary/Motivation:

Removes the use of namespace packages from pyutilib. After we consolidated the bulk of PyUtilib into a single repository, there aren't (maintained) pyutilib capabilities outside of this repository. Removing the namespace packaging simplifies several things (including plugin imports)

Changes proposed in this PR:

  • remove namespace packages pyutilib and pyutilib.component

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@coveralls
Copy link

coveralls commented Mar 13, 2020

Coverage Status

Coverage decreased (-0.06%) to 61.062% when pulling 37a8c89 on jsiirola:remove-namespace-packages into f61be88 on PyUtilib:master.

@jsiirola
Copy link
Contributor Author

@whart222: please take a look at this and see if you agree. This is a rework of #82 to only include the part related to the removal of the namespace packages.

@whart222
Copy link
Contributor

@jsiirola I think this looks OK. This also includes deferral of some logic w.r.t. egg plugins for pyutilib.component. I think you should add documentation about that change to the PR, but I don't think we need to separate that into a separate PR.

FYI, I looked at the other pyutilib.* packages hosted on PyPI, and I checked if they are actively being used within GitHub projects. I couldn't find any, and hence I think there's minimal risk that this change will be disruptive for PyUtilib users who may be pulling-in multiple PyUtilib packages and relying on this namespacing feature. Further, those packages are quite old, so I would encourage users to discontinue their use in any case.

Copy link
Contributor

@whart222 whart222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added comments separately. I'm not sure if the coverage checks are meaningful, but the code changes seem fine.

@jsiirola
Copy link
Contributor Author

I added some (minimal) documentation for the deferred import of pkg_resources in the Egg loader.

@jsiirola jsiirola merged commit e6c1913 into PyUtilib:master Mar 16, 2020
@jsiirola jsiirola deleted the remove-namespace-packages branch March 16, 2020 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants