MAINT: fix more compiler warnings #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 86.23% (diff: 100%)@@ master #265 diff @@
==========================================
Files 20 20
Lines 3045 3043 -2
Methods 45 45
Messages 0 0
Branches 521 520 -1
==========================================
Hits 2624 2624
+ Misses 370 368 -2
Partials 51 51
|
They were of this form (with Clang):
pywt/_extensions/_swt.c:5163:59: warning: comparison of integers of different
signs: 'int' and 'size_t'
(aka 'unsigned long') [-Wsign-compare]
for (__pyx_t_13 = (__pyx_v_start_level + 1); __pyx_t_13 < __pyx_t_16;
rgommers
changed the title
python setup.py build_clib.
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All compiler warnings on OS X + Clang are now gone, except for the unavoidable ones coming from Cython.