-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated bootstrap #295
Updated bootstrap #295
Conversation
delijati
commented
Feb 16, 2016
- Bootstrap css, js updated to 3.3.6
- Merged fix pull request Fixes for boostrap v3.0.3 #195
- Tested with deform2demo
To provide justification for the changes in the template files, see example markup for Bootstrap's horizontal form layout. @delijati travis-ci build fails due to deform testing on Python 3.2, which is no longer supported in pip and is EOL as of February 2016. We should remove py32 from testing. We should also add testing for Python 3.5. Would you please modify your Otherwise, this looks good. |
Done |
Yeah right tox is still failing because it uses the master tox.ini. Locally all test are passing. |
@delijati I think Travis-CI tries to fetch and merge your PR before building, so it should pick up yours: I think we recently ran into a similar issue with removing 3.2/adding 3.5 on another Pylons Project repo (Pyramid? Colander?). @mmerickel @bertjwregeer can you look into this? This is beyond me. |
@delijati can you re-push your |
Done now should everything work. |
@delijati @tseaver still failing on travis https://travis-ci.org/Pylons/deform/jobs/109597085 Either of you know how to get travis-ci to install a py35 interpreter? |
@delijati compare against Pyramid's repo for |
You have to use the matrix based building on Travis to get it to install Python 3.5, unfortunately. I'll work on a PR that fixes that shortly, and since it looks like I have access to this repo push that change out to master. |
Please merge master into this branch. Hopefully that should allow things to build correctly this time around. I fixed all the issues with travis. |
Renamed README.txt to README.rst Adding badges to README.rst
I also added the travis badge to README.rst |
@stevepiercy can you merge it and make a new release ? |
I think only @mcdonc has that ability, but I'm not sure. https://pypi.python.org/pypi/deform Someone more familiar with deform than I should do the merge and release, perhaps @bertjwregeer? I only have power to merge. |
I can merge it, however, here's the rub, no-one other than @mcdonc himself has the ability to release a new deform, and as can be seen from PyPi, he hasn't done so for a long time. Your best bet is to tag this locally after this is merged, and make your own local package and then use in your projects. You can also refer to this within pip using the git URL. I already maintain a huge variety of projects, and I personally don't use deform anymore (just the underlying library colander), so I don't feel comfortable being in charge of releases. |
Updated bootstrap to version 3.3.6