fix stdin on windows #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmerickel
force-pushed
the
pipe-forwarder
branch
2 times, most recently
from
1822c2f
to
cc3c446
Compare
mmerickel
force-pushed
the
pipe-forwarder
branch
from
cc3c446
to
e46d451
Compare
Closed
mmerickel
added a commit
that referenced
this pull request
Mar 10, 2017
This was referenced Mar 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As long as we're using multiprocessing this appears to be the only way to forward stdin to the child process on windows.
The core of the issue is that stdin is coupled to the parent process and cannot be duplicated to the child unless the child was created with stdin... and multiprocessing does not do this. SO YEAH, instead I'm duplicating my own pipe and spawning a thread that reads from stdin and sends it to the pipe. Sigh.
Anyway I tested this on windows 7 and windows 10 in environments where I was able to reproduce the issue and it seems to be working now.