allow overriding the default monitor via env var #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure it is a huge security concern... just not sure if it is good API. The reloader in werkzeug just has a static list IIRC. |
|
I'm fairly against static lists in general but I also don't care about this all that much other than as a hook to turn off watchdog if desired. |
|
I'm a +1 on this change then. I don't see any issues and it allows you to effectively override as necessary. |
mmerickel
force-pushed
the
override-monitor
branch
2 times, most recently
from
7d2d80b
to
f3f6c88
Compare
mmerickel
force-pushed
the
override-monitor
branch
from
f3f6c88
to
874c8fd
Compare
mmerickel
force-pushed
the
override-monitor
branch
from
70549f0
to
e9d41cd
Compare
mmerickel
added a commit
that referenced
this pull request
May 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative would be to support setuptools entry points to make this slightly safer than loading arbitrary python code from an environment variable. How much of a concern is this? I wanted to avoid statically defining 'watchdog' and 'poll' as hard-coded strings so I left it as a dotted python path. Entry points would be the flexible way to avoid hard coding strings.