ignore changes in installed packages #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this change a lot, only time I use the site-packages changing to test something is when I do an editable install of some sub-package but not the main and want hupper to pick up those changes... Hit enter too soon. I'd be okay with an env flag to override this behaviour! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this includes stdlib and site-packages
my feeling is that there's no reason to support an opt-out here, we should just ignore these files which will greatly reduce the number of files being watched by default, maybe I'd allow some sort of
HUPPER_IGNORE_INSTALLED_PACKAGES=noenv var if people felt strongly about it or a flag passed at runtime, but then any library integrating hupper (like pserve) would need a way to expose it