Cope with *.pyc files outside __pycache__ #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PEP-3147 allows solitary *.pyc files outside of __pycache__, however importlib.source_from_cache() raises a ValueError for such files. Fall back to the Python 2.x method if that happens, i.e. strip the trailing 'c' off the file name. Signed-off-by: Nils Philippsen <nils@tiptoe.de>
|
With Python 3.5 and below being EOL, I would recommend updating this to Python 3.6 or higher only, and we can bump the Python versions that Hupper is compatible with. I'd like @mmerickel's input on that suggestion though! |
|
I'm merely an indirect consumer of hupper on a very current Python version, so personally I'm fine with it. However (and again personally), I'd hold off on that until code outside of |
|
Thanks @nphilipp. Sorry for the slowness but LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope this pull request finds you well.
PEP-3147 allows solitary
*.pycfiles outside of__pycache__, howeverimportlib.source_from_cache()raises aValueErrorfor such files. Fall back to the Python 2.x method if that happens, i.e. strip the trailingcoff the file name.